Switch the default nonsymmetric eigendecomposition implementation to use cusolver. #32490
+353
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_816815747
branch
3 times, most recently
from
92cd12a to
c0c8599
Compare
…use cusolver. This regresses a test that checks that eigendecompositions behave well if provided NaNs as input. I think this is the right tradeoff, however, since the cusolver implementation should be faster and the old implementation is still available. Deprecate the use_magma argument to `lax.linalg.eig`, replace it with an `implementation` argument. This PR builds on an partial PR from @dfm. Fixes #27265 PiperOrigin-RevId: 817628185
copybara-service
bot
force-pushed
the
test_816815747
branch
from
c0c8599 to
97b001a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the default nonsymmetric eigendecomposition implementation to use cusolver.
This regresses a test that checks that eigendecompositions behave well if provided NaNs as input. I think this is the right tradeoff, however, since the cusolver implementation should be faster and the old implementation is still available.
Deprecate the use_magma argument to
lax.linalg.eig, replace it with animplementationargument.This PR builds on an partial PR from @dfm.
Fixes #27265